capture stack traces in worker panics #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mumbleskates
force-pushed
the
stacktraces
branch
from
72acf8c
to
1b3c69d
Compare
qslug
approved these changes
Sep 24, 2024
| } | ||
| } | ||
|
|
||
| g.panicked.CompareAndSwap(nil, &wp) |
There was a problem hiding this comment.
Just curious, why CompareAndSwap? Is there a risk of setting g.panicked twice?
There was a problem hiding this comment.
pretty positive i just wanted to make sure that specifically the first panic sticks, rather than just "any panic who cares"
| // nicely with the testing lib, but there doesn't seem to be any good | ||
| // way to xfail a golang test. As it happens t.Fatal() just sets a fail | ||
| // flag and then calls Goexit() anyway; if we treat nil recover() values | ||
| // as Goexit() (guaranteed since 1.21 with the advent of PanicNilError) |
There was a problem hiding this comment.
... realizes what it means that panic(nil) use to recover() as nil
There was a problem hiding this comment.
there is some deep lore to how panic(nil) used to work (and be worked around)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we want to know where panics are happening inside parallelized functions :)